sion/sionrui
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

短信模板的单元测试

Browse Source
This commit is contained in:
YunaiV
2021-04-07 00:04:02 +08:00
parent fbbcd2717a
commit 4a40771057
4 changed files with 167 additions and 76 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/main/java/cn/iocoder/dashboard/modules/system/service/sms/impl/SysSmsTemplateServiceImpl.java
View File

@@ -82,8 +82,15 @@ public class SysSmsTemplateServiceImpl implements SysSmsTemplateService {
public void updateSmsTemplate(SysSmsTemplateUpdateReqVO updateReqVO) {
// 校验存在
this.validateSmsTemplateExists(updateReqVO.getId());
// 校验短信渠道
SysSmsChannelDO channelDO = checkSmsChannel(updateReqVO.getChannelId());
// 校验短信编码是否重复
checkSmsTemplateCodeDuplicate(updateReqVO.getId(), updateReqVO.getCode());
// 更新
SysSmsTemplateDO updateObj = SysSmsTemplateConvert.INSTANCE.convert(updateReqVO);
updateObj.setParams(parseTemplateContentParams(updateObj.getContent()));
updateObj.setChannelCode(channelDO.getCode());
smsTemplateMapper.updateById(updateObj);
}
@@ -121,7 +128,8 @@ public class SysSmsTemplateServiceImpl implements SysSmsTemplateService {
return smsTemplateMapper.selectList(exportReqVO);
}
private SysSmsChannelDO checkSmsChannel(Long channelId) {
@VisibleForTesting
public SysSmsChannelDO checkSmsChannel(Long channelId) {
SysSmsChannelDO channelDO = smsChannelService.getSmsChannel(channelId);
if (channelDO == null) {
throw exception(SMS_CHANNEL_NOT_EXISTS);
@@ -132,7 +140,8 @@ public class SysSmsTemplateServiceImpl implements SysSmsTemplateService {
return channelDO;
}
private void checkSmsTemplateCodeDuplicate(Long id, String code) {
@VisibleForTesting
public void checkSmsTemplateCodeDuplicate(Long id, String code) {
SysSmsTemplateDO template = smsTemplateMapper.selectByCode(code);
if (template == null) {
return;